Change in osmo-msc[master]: fix crash for unknown MI during Paging Response

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/19722 )


Change subject: fix crash for unknown MI during Paging Response
......................................................................

fix crash for unknown MI during Paging Response

Related: OS#4724
Related: I40496bbccbbd9c496cfa57df49e26f124a2b1554 (osmo-ttcn3-hacks)
Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
---
M src/libmsc/gsm_04_08.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/19722/1

diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 15303b5..6bd82d0 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1185,7 +1185,12 @@
 	vsub = msc_a_vsub(msc_a);
 	if (!vsub) {
 		LOG_MSC_A_CAT(msc_a, DRR, LOGL_ERROR, "subscriber not allowed to do a Paging Response\n");
-		msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
+		/* Above MSC_A_USE_PAGING_RESPONSE may already have been removed by a forced release, put that use only
+		 * if it still exists. (see msc_a_fsm_releasing_onenter()) */
+		if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_PAGING_RESPONSE))
+			msc_a_put(msc_a, MSC_A_USE_PAGING_RESPONSE);
+
 		return -EIO;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
Gerrit-Change-Number: 19722
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200819/c5b16a0a/attachment.htm>