Change in osmo-pcu[master]: Introduce log macro helper LOGPMS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Aug 19 09:00:43 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19706 )

Change subject: Introduce log macro helper LOGPMS
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/19706/1/src/gprs_ms.h 
File src/gprs_ms.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/19706/1/src/gprs_ms.h@302 
PS1, Line 302: PRIu8 ", %" PRIu8 "/%" PRIu8
> If there's a specific standard format for uint8_t, why not use it? IMHo it's good practice to always […]
At least because such format string looks cumbersome and harder to read compared to 'inline' format specifiers.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib304ced06531a5154b7ec8bf87f9717dfd7d1397
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2020 09:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200819/0f06207f/attachment.htm>


More information about the gerrit-log mailing list