Change in osmo-pcu[master]: pdch: rcv pkt meas rep: Allocate MS object early in path and use it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Aug 19 08:58:14 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19707 )

Change subject: pdch: rcv pkt meas rep: Allocate MS object early in path and use it
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/19707/1/src/gprs_rlcmac_meas.cpp 
File src/gprs_rlcmac_meas.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19707/1/src/gprs_rlcmac_meas.cpp@46 
PS1, Line 46: 	LOGPMS(ms, DRLCMACMEAS, LOGL_INFO, "Rx Measurement Report:");
> this looks like an unrelated change/hunk that might be better merged into the introduction of LOGPMS […]
Well the other changes in this patch are a prerequisite for this line change (having ms object in all cases), and imho it goes well in this same patch as a user of the refactoring done in the other place.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19707
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3ec7eb970310698dd228ae6ad65ec5ca833bab3f
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2020 08:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200819/638a02c8/attachment.htm>


More information about the gerrit-log mailing list