Change in osmo-mgw[master]: mgcp_protocol: log when endpoint is unavailable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Aug 18 19:00:01 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19708 )


Change subject: mgcp_protocol: log when endpoint is unavailable
......................................................................

mgcp_protocol: log when endpoint is unavailable

When endpoints become unavailable when MDCX/CRCX/DLCX are executed on
them a major problem may be the cause, lets make sure that those events
are logged.

Change-Id: I059b7e29f960e75a53bfb5dfb2b83ab3d79e84f3
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/08/19708/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 6a533c3..4dc0f55 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -748,6 +748,8 @@
 	LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: creating new connection ...\n");
 	if (!mgcp_endp_avail(endp)) {
 		rate_ctr_inc(&rate_ctrs->ctr[MGCP_CRCX_FAIL_AVAIL]);
+		LOGPENDP(endp, DLMGCP, LOGL_ERROR,
+			 "CRCX: selected endpoint not available!\n");
 		return create_err_response(NULL, 501, "CRCX", p->trans);
 	}
 
@@ -1017,6 +1019,8 @@
 
 	if (!mgcp_endp_avail(endp)) {
 		rate_ctr_inc(&rate_ctrs->ctr[MGCP_MDCX_FAIL_AVAIL]);
+		LOGPENDP(endp, DLMGCP, LOGL_ERROR,
+			 "MDCX: selected endpoint not available!\n");
 		return create_err_response(NULL, 501, "MDCX", p->trans);
 	}
 
@@ -1243,6 +1247,8 @@
 
 	if (!mgcp_endp_avail(endp)) {
 		rate_ctr_inc(&rate_ctrs->ctr[MGCP_DLCX_FAIL_AVAIL]);
+		LOGPENDP(endp, DLMGCP, LOGL_ERROR,
+			 "DLCX: selected endpoint not available!\n");
 		return create_err_response(NULL, 501, "DLCX", p->trans);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I059b7e29f960e75a53bfb5dfb2b83ab3d79e84f3
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200818/f58cc272/attachment.htm>


More information about the gerrit-log mailing list