Change in osmo-trx[master]: osmo-trx-ipc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 17 17:44:13 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19641 )

Change subject: osmo-trx-ipc
......................................................................


Patch Set 10:

(10 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c 
File Transceiver52M/device/ipc/ipc_chan.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@66 
PS10, Line 66: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@99 
PS10, Line 99: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@130 
PS10, Line 130: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@138 
PS10, Line 138: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@168 
PS10, Line 168: 			     "message type (%d) with ZERO "
Not critical, but I still find formatting of this statement looking odd.


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@225 
PS10, Line 225: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@230 
PS10, Line 230: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@248 
PS10, Line 248: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_chan.c@256 
PS10, Line 256: DMAIN
DDEV?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg 
File doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg@17 
PS10, Line 17: egprs disable
duplicate, see line #24



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19641
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 17 Aug 2020 17:44:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/b19fbbfb/attachment.htm>


More information about the gerrit-log mailing list