Change in osmo-ttcn3-hacks[master]: bsc CBSP: expect zero-payload ETWS CMD after CBSP RESET

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636 )

Change subject: bsc CBSP: expect zero-payload ETWS CMD after CBSP RESET
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636/1//COMMIT_MSG@10 
PS1, Line 10: BTSes
> all affected BTSs.  The RESET comamnd contains a list of cell identifiers. […]
indeed.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636/1/bsc/BSC_Tests_CBSP.ttcn 
File bsc/BSC_Tests_CBSP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636/1/bsc/BSC_Tests_CBSP.ttcn@197 
PS1, Line 197: 	[] IPA_RSL[0].receive(zero_payload) { log("CBSP: disabled broadcast on bts 0"); }
> the zero-length RSL ETWS command does not disable all CBSP broadcast, but only the ETWS PN broadcast […]
In fact I am only marginally familiar with this area, I don't know what other broadcast besides PN exists.
Is the point that more broadcast disabling is missing in osmo-bsc's CBSP RESET procedure?
Or is it just that the naming of this function and commit log should say "pn"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifee313369a433a6a638c5fffdedee5363b8e47c2
Gerrit-Change-Number: 19636
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 17 Aug 2020 15:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/510853a3/attachment.htm>