Change in libosmocore[master]: sockaddr_str: add osmo_sockaddr_str_from_str2() which doesn't set the...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 17 10:36:14 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19142 )

Change subject: sockaddr_str: add osmo_sockaddr_str_from_str2() which doesn't set the port
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/19142/10/src/sockaddr_str.c 
File src/sockaddr_str.c:

https://gerrit.osmocom.org/c/libosmocore/+/19142/10/src/sockaddr_str.c@201 
PS10, Line 201: 	if (!sockaddr_str)
I would drop this check completely (for documentation as well), but ok. It makes no sense to call this function on a NULL pointer.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifd4e282586b8bd40b912a9f1c25f9e8208420106
Gerrit-Change-Number: 19142
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Aug 2020 10:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/6c80f928/attachment.htm>


More information about the gerrit-log mailing list