Change in osmo-trx[master]: osmo-trx-ipc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 17 10:04:30 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19641 )

Change subject: osmo-trx-ipc
......................................................................


Patch Set 7:

(3 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/ipc_chan.c 
File Transceiver52M/device/ipc/ipc_chan.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/ipc_chan.c@52 
PS7, Line 52: fprintf
can we migrate all of those fprintf/printf statements to the osmocom logging API, please?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/ipc_shm.c 
File Transceiver52M/device/ipc/ipc_shm.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/ipc_shm.c@67 
PS7, Line 67: fprintf
likewise here in this function, please use the osmocom logging framework.  and in fact, osmo_panic() might be a good idea if you want to log something + exit.


https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/shm.c 
File Transceiver52M/device/ipc/shm.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/7/Transceiver52M/device/ipc/shm.c@40 
PS7, Line 40: #ifdef ENCDECDEBUG
            : 		fprintf(stderr, "decode: smpl_buf %d at offset %u\n", i, stream_raw->buffer_offset[i]);
            : #endif
would make sense to #define a DEBUGENCDEC() macro to avoid #ifdef/endif around every line of related logging.  The macro can then either be #defined away, or #defined to fprintf - or even anything else.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19641
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 17 Aug 2020 10:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/ca6dc384/attachment.htm>


More information about the gerrit-log mailing list