Change in simtrace2[master]: dfu: Shrink code by 144 bytes (by not calling PIO_InitializeInterrupts)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 16 13:58:40 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/19673 )

Change subject: dfu: Shrink code by 144 bytes (by not calling PIO_InitializeInterrupts)
......................................................................

dfu: Shrink code by 144 bytes (by not calling PIO_InitializeInterrupts)

We are not using any PIO interrupts from DFU mode.  It's only used in
the main application firmware (verified by "git grep PIO_ConfigureIt")

Change-Id: Id1447af519df3183061f3d3f156a8dd84789af16
---
M firmware/apps/dfu/main.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c
index 2e80884..aa0adfd 100644
--- a/firmware/apps/dfu/main.c
+++ b/firmware/apps/dfu/main.c
@@ -265,8 +265,6 @@
 	PIO_Clear(&pinsLeds[LED_NUM_GREEN]);
 #endif
 
-	PIO_InitializeInterrupts(0);
-
 	EEFC_ReadUniqueID(g_unique_id);
 
 	printf("\n\r\n\r"

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/19673
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Id1447af519df3183061f3d3f156a8dd84789af16
Gerrit-Change-Number: 19673
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200816/b8183a7a/attachment.htm>


More information about the gerrit-log mailing list