Change in libosmocore[master]: vty cpu sched: do not assert if sched impossible

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Fri Aug 14 01:15:27 UTC 2020


Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19639 )


Change subject: vty cpu sched: do not assert if sched impossible
......................................................................

vty cpu sched: do not assert if sched impossible

Shared code might be used by applications that have no vty, so sched
can't be initialized, do not assert and break everything in this case, a
warning should suffice.

Change-Id: Ic40075df8d4cf9fe8f1d711f899dae9a4b5b0928
---
M src/vty/cpu_sched_vty.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/19639/1

diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c
index 3b6067a..b962284 100644
--- a/src/vty/cpu_sched_vty.c
+++ b/src/vty/cpu_sched_vty.c
@@ -631,7 +631,10 @@
 	int rc = 0;
 
 	/* Assert subsystem was inited and structs are preset */
-	OSMO_ASSERT(sched_vty_opts);
+	if (!sched_vty_opts) {
+		LOGP(DLGLOBAL, LOGL_FATAL, "Setting cpu-affinity mask impossible: no opts!\n");
+		return 0;
+	}
 
 	if (pthread_getname_np(pthread_self(), name, sizeof(name)) == 0)
 		has_name = true;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic40075df8d4cf9fe8f1d711f899dae9a4b5b0928
Gerrit-Change-Number: 19639
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200814/51b4f482/attachment.htm>


More information about the gerrit-log mailing list