Change in osmo-sip-connector[master]: sip: Specify invite contact tag

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584 )

Change subject: sip: Specify invite contact tag
......................................................................

sip: Specify invite contact tag

Version 1.12.12 of libsofia-sip-ua no longer automatically generates a
contact header element from the local ip address and port. Specifying
the contact tag does not break operation with the existing
library (1.12.11), but allows for operation on a system with
freeswitch 1.10.4 or later installed, which is built against this new
version of libsofia-sip-ua.

Change-Id: I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246
---
M src/sip.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/sip.c b/src/sip.c
index c635542..61916c9 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -597,6 +597,9 @@
 				called_num,
 				agent->app->sip.remote_addr,
 				agent->app->sip.remote_port);
+	char *contact = talloc_asprintf(leg, "sip:%s:%d",
+					agent->app->sip.local_addr,
+					agent->app->sip.local_port);
 	char *sdp = sdp_create_file(leg, other, sdp_sendrecv);
 
 	leg->state = SIP_CC_INITIAL;
@@ -604,6 +607,7 @@
 	nua_invite(leg->nua_handle,
 			SIPTAG_FROM_STR(from),
 			SIPTAG_TO_STR(to),
+			SIPTAG_CONTACT_STR(contact),
 			NUTAG_MEDIA_ENABLE(0),
 			SIPTAG_CONTENT_TYPE_STR("application/sdp"),
 			SIPTAG_PAYLOAD_STR(sdp),
@@ -612,6 +616,7 @@
 	leg->base.call->remote = &leg->base;
 	talloc_free(from);
 	talloc_free(to);
+	talloc_free(contact);
 	talloc_free(sdp);
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246
Gerrit-Change-Number: 19584
Gerrit-PatchSet: 3
Gerrit-Owner: matt9j <matt9j at cs.washington.edu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: matt9j <matt9j at cs.washington.edu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200813/b2b52bfb/attachment.htm>