This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19217 )
Change subject: bsc: test RR Channel Release cause codes from Clear Command cause codes
......................................................................
bsc: test RR Channel Release cause codes from Clear Command cause codes
Invoke Clear Command with various Cause codes and verify that the RR Channel
Release reflects them.
Depends: I734cc55c501d61bbdadee81a223b26f9df57f959 (osmo-bsc)
Change-Id: Ie6c99f28b610a67f2d59ec00b3541940e882251b
---
M bsc/BSC_Tests.ttcn
M library/GSM_RR_Types.ttcn
2 files changed, 89 insertions(+), 8 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 660e758..15d83da 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1499,7 +1499,8 @@
boolean expect_rll_rel_req := true,
boolean handle_rll_rel := true,
boolean is_csfb := false,
- template CellSelIndValue csfb_expect_cells := omit
+ template CellSelIndValue csfb_expect_cells := omit,
+ template RR_Cause expect_rr_cause := ?
) runs on test_CT {
var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
@@ -1507,6 +1508,9 @@
var boolean got_rr_chan_rel := false;
var boolean got_rll_rel_req := false;
var ASP_RSL_Unitdata ud;
+ var RSL_IE_Body l3_ie;
+ var PDU_ML3_NW_MS l3;
+ var RR_Cause got_cause;
log("f_expect_chan_rel() expecting: expect_deact_sacch=", expect_deact_sacch, " expect_rr_chan_rel=", expect_rr_chan_rel,
" expect_rll_rel_req=", expect_rll_rel_req);
alt {
@@ -1517,13 +1521,13 @@
[is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE_CSFB))) -> value ud {
got_rr_chan_rel := true;
+ if (f_rsl_find_ie(ud.rsl, RSL_IE_L3_INFO, l3_ie) == false) {
+ setverdict(fail, "cannot find L3");
+ mtc.stop;
+ }
+ l3 := dec_PDU_ML3_NW_MS(l3_ie.l3_info.payload);
+
if (not istemplatekind(csfb_expect_cells, "omit")) {
- var RSL_IE_Body l3_ie;
- if (f_rsl_find_ie(ud.rsl, RSL_IE_L3_INFO, l3_ie) == false) {
- setverdict(fail, "cannot find L3");
- mtc.stop;
- }
- var PDU_ML3_NW_MS l3 := dec_PDU_ML3_NW_MS(l3_ie.l3_info.payload);
var CellSelIndValue cells := dec_CellSelIndValue(
l3.msgs.rrm.channelRelease.cellSelectionIndicator.cellSelectionIndicatorValue);
@@ -1535,10 +1539,38 @@
setverdict(fail, "Received CSFB cells list on RR Channel Release does not match expectations");
}
}
+
+ if (not istemplatekind(expect_rr_cause, "omit")) {
+ int2enum(oct2int(l3.msgs.rrm.channelRelease.rRCause.valuePart), got_cause);
+ log("GOT CAUSE CODE: ", l3.msgs.rrm.channelRelease.rRCause.valuePart, " = ", got_cause);
+ if (match(got_cause, expect_rr_cause)) {
+ setverdict(pass);
+ } else {
+ log("EXPECTED CAUSE CODE: ", expect_rr_cause);
+ setverdict(fail, "Received RR Channel Release Cause code does not match expectations");
+ }
+ }
repeat;
}
- [not is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE))) {
+ [not is_csfb] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_DATA_REQ(rsl_chan_nr, ?, decmatch tr_RRM_RR_RELEASE))) -> value ud {
got_rr_chan_rel := true;
+
+ if (not istemplatekind(expect_rr_cause, "omit")) {
+ if (f_rsl_find_ie(ud.rsl, RSL_IE_L3_INFO, l3_ie) == false) {
+ setverdict(fail, "cannot find L3");
+ mtc.stop;
+ }
+ l3 := dec_PDU_ML3_NW_MS(l3_ie.l3_info.payload);
+
+ int2enum(oct2int(l3.msgs.rrm.channelRelease.rRCause.valuePart), got_cause);
+ log("GOT CAUSE CODE: ", l3.msgs.rrm.channelRelease.rRCause.valuePart, " = ", got_cause);
+ if (match(got_cause, expect_rr_cause)) {
+ setverdict(pass);
+ } else {
+ log("EXPECTED CAUSE CODE: ", expect_rr_cause);
+ setverdict(fail, "Received RR Channel Release Cause code does not match expectations");
+ }
+ }
repeat;
}
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(tr_RSL_REL_REQ(rsl_chan_nr, ?))) {
@@ -1688,6 +1720,34 @@
setverdict(pass);
}
+private function f_tc_chan_rel_rr_cause(myBSSMAP_Cause clear_cmd_cause, template RR_Cause expect_rr_cause)
+runs on test_CT
+{
+ var DchanTuple dt;
+
+ dt := f_est_dchan('23'O, 23, '00010203040506'O);
+ var BssmapCause cause := 0;
+ BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSMAP_ClearCommand(enum2int(clear_cmd_cause))));
+ BSSAP.receive(tr_BSSAP_DATA_ind(dt.sccp_conn_id, tr_BSSMAP_ClearComplete)) {
+ BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
+ }
+
+ f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false, expect_rr_cause := expect_rr_cause);
+ setverdict(pass);
+}
+
+/* Test that Clear Command cause codes affect the RR Channel Release cause code */
+testcase TC_chan_rel_rr_cause() runs on test_CT {
+ f_init(1);
+
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_CALL_CONTROL, GSM48_RR_CAUSE_NORMAL);
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_HANDOVER_SUCCESSFUL, GSM48_RR_CAUSE_NORMAL);
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_PREEMPTION, GSM48_RR_CAUSE_PREMPTIVE_REL);
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE, GSM48_RR_CAUSE_PROT_ERROR_UNSPC);
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, GSM48_RR_CAUSE_ABNORMAL_UNSPEC);
+ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_EQUIPMENT_FAILURE, GSM48_RR_CAUSE_ABNORMAL_UNSPEC);
+}
+
/* Test behavior if RSL EST IND for non-active channel */
testcase TC_rll_est_ind_inact_lchan() runs on test_CT {
timer T := 2.0;
@@ -6231,6 +6291,7 @@
execute( TC_chan_rel_hard_rlsd_ms_dead() );
execute( TC_chan_rel_a_reset() );
execute( TC_chan_rel_sccp_tiar_timeout() );
+ execute( TC_chan_rel_rr_cause() );
execute( TC_outbound_connect() );
diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index e54bc92..2c607a7 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -113,6 +113,26 @@
INTERSYS_TO_EUTRAN_HO_CMD ('01100110'B)
} with { variant "FIELDLENGTH(8)" };
+ type enumerated RR_Cause {
+ GSM48_RR_CAUSE_NORMAL ('00'O),
+ GSM48_RR_CAUSE_ABNORMAL_UNSPEC ('01'O),
+ GSM48_RR_CAUSE_ABNORMAL_UNACCT ('02'O),
+ GSM48_RR_CAUSE_ABNORMAL_TIMER ('03'O),
+ GSM48_RR_CAUSE_ABNORMAL_NOACT ('04'O),
+ GSM48_RR_CAUSE_PREMPTIVE_REL ('05'O),
+ GSM48_RR_CAUSE_HNDOVER_IMP ('08'O),
+ GSM48_RR_CAUSE_CHAN_MODE_UNACCT ('09'O),
+ GSM48_RR_CAUSE_FREQ_NOT_IMPL ('0a'O),
+ GSM48_RR_CAUSE_CALL_CLEARED ('41'O),
+ GSM48_RR_CAUSE_SEMANT_INCORR ('5f'O),
+ GSM48_RR_CAUSE_INVALID_MAND_INF ('60'O),
+ GSM48_RR_CAUSE_MSG_TYPE_N ('61'O),
+ GSM48_RR_CAUSE_MSG_TYPE_N_COMPAT('62'O),
+ GSM48_RR_CAUSE_COND_IE_ERROR ('64'O),
+ GSM48_RR_CAUSE_NO_CELL_ALLOC_A ('65'O),
+ GSM48_RR_CAUSE_PROT_ERROR_UNSPC ('6f'O)
+ } with { variant "FIELDLENGTH(8)" };
+
type octetstring RestOctets with { variant "PADDING(yes), PADDING_PATTERN('00101011'B)" };
type hexstring GsmBcdString with { variant "HEXORDER(low)" };
type GsmBcdString BcdMccMnc with { variant "FIELDLENGTH(6)" };
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19217
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie6c99f28b610a67f2d59ec00b3541940e882251b
Gerrit-Change-Number: 19217
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/24cc7cca/attachment.htm>