Change in osmo-ttcn3-hacks[master]: bsc: Add statsd checker and use it in TC_assignment_sign

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19582 )

Change subject: bsc: Add statsd checker and use it in TC_assignment_sign
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19582/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19582/1/bsc/BSC_Tests.ttcn@788 
PS1, Line 788: 
             : function f_init_statsd(charstring id) runs on test_CT {
             : 	id := id & "-STATS";
             : 
             : 	vc_STATSD := StatsD_Checker_CT.create(id);
             : 	vc_STATSD.start(StatsD_Checker.main(mp_test_ip, mp_bsc_statsd_port));
             : }
this could become part of the statsd module, so we don't have to replicate it in every bts/bsc/msc/... test suite.  You could use a function signature like this:

f_init_statsd(charstring id, inout StatsD_Checker_CT vc_STATSD, charsrtring test_ip, integer port)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8526b645dc4af59adcc1855699421a026f505c1d
Gerrit-Change-Number: 19582
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 12 Aug 2020 18:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/1edbdc11/attachment.htm>