Change in osmo-bsc[master]: gsm_04_08_rr: block EMERGENCY SETUP when EMERGENCY CALLS are denied

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Aug 12 10:36:59 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19565 )

Change subject: gsm_04_08_rr: block EMERGENCY SETUP when EMERGENCY CALLS are denied
......................................................................


Patch Set 1:

(3 comments)

Mostly cosmetic comments.

https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c 
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@995 
PS1, Line 995: if(
coding style


https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@997 
PS1, Line 997: LOG_LCHAN
This log statement seems to be longer than 120 chars, would be nice to split it.


https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@1002 
PS1, Line 1002: 				LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are denied on this BSC (check BTS config!)\n");
Same here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia6eb38370ce4165d221d2ffbe1cd105c0628313c
Gerrit-Change-Number: 19565
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Aug 2020 10:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/18dcd104/attachment.htm>


More information about the gerrit-log mailing list