Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: check template before using isvalue()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Aug 11 20:59:46 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19566 )


Change subject: MSC_ConnectionHandler: check template before using isvalue()
......................................................................

MSC_ConnectionHandler: check template before using isvalue()

The function f_establish_fully may be called with template ass_tpl set
to "omit". In this case we must make sure that we do not pass ass_tpl on
to isvalue().

Change-Id: Ie094e5b56a851351671327b475d5e597a5a94bf6
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/19566/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 7d8fce1..7b8f087 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -1005,7 +1005,7 @@
 	var BSSMAP_FIELD_CodecType codecType;
 	timer T := 10.0;
 
-	if (isvalue(ass_tpl.pdu.bssmap.assignmentRequest.codecList)) {
+	if (not istemplatekind(ass_tpl, "omit") and isvalue(ass_tpl.pdu.bssmap.assignmentRequest.codecList)) {
 		codecType := valueof(ass_tpl.pdu.bssmap.assignmentRequest.codecList.codecElements[0].codecType);
 	} else {
 		/* Make sure a meaningful default is assigned in case the

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19566
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie094e5b56a851351671327b475d5e597a5a94bf6
Gerrit-Change-Number: 19566
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200811/5e6eea01/attachment.htm>


More information about the gerrit-log mailing list