Change in osmo-bts[master]: common: Support setting rt prio through new libosmovty sched VTY cmds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 10 20:10:50 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19444 )

Change subject: common: Support setting rt prio through new libosmovty sched VTY cmds
......................................................................

common: Support setting rt prio through new libosmovty sched VTY cmds

We gain other features from libosmovty for free, like configuring
cpu-affinity of the only thread in the process.

Depends: libosmocore.git Change-Id If76a4bd2cc7b3c7adf5d84790a944d78be70e10a
Depends: osmo-gsm-masnuals.git Change-Id Icd75769ef630c3fa985fc5e2154d5521689cdd3c

Related: SYS#4986
Change-Id: Ice46e406b84fa11afcc7ba31e521e7677df73cf3
---
M TODO-RELEASE
M doc/manuals/osmobts-usermanual.adoc
M src/common/main.c
3 files changed, 9 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 1dd5e79..72e4757 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1 +1,2 @@
-* update libosmocore dependency to > 1.3.x for lapdm_channel_init3()
+* update libosmocore dependency to > 1.3.x for lapdm_channel_init3(), osmo_cpu_sched_vty_init()
+* update osmo-gsm-manuals dependency to > 0.3.0 for vty_cpu_sched.adoc include.
diff --git a/doc/manuals/osmobts-usermanual.adoc b/doc/manuals/osmobts-usermanual.adoc
index 55087b2..b1b0747 100644
--- a/doc/manuals/osmobts-usermanual.adoc
+++ b/doc/manuals/osmobts-usermanual.adoc
@@ -30,6 +30,8 @@
 
 include::{srcdir}/chapters/architecture.adoc[]
 
+include::./common/chapters/vty_cpu_sched.adoc[]
+
 include::./common/chapters/trx_if.adoc[]
 
 include::./common/chapters/control_if.adoc[]
diff --git a/src/common/main.c b/src/common/main.c
index f4dc505..dfdc2a7 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -38,6 +38,7 @@
 #include <osmocom/core/application.h>
 #include <osmocom/vty/telnet_interface.h>
 #include <osmocom/vty/logging.h>
+#include <osmocom/vty/cpu_sched_vty.h>
 #include <osmocom/core/gsmtap_util.h>
 #include <osmocom/core/gsmtap.h>
 
@@ -74,7 +75,7 @@
 		"  -T	--timestamp	Prefix every log line with a timestamp\n"
 		"  -V	--version	Print version information and exit\n"
 		"  -e 	--log-level	Set a global log-level\n"
-		"  -r	--realtime PRIO	Use SCHED_RR with the specified priority\n"
+		"  -r	--realtime PRIO	Use SCHED_RR with the specified priority (deprecated, use VTY instead)\n"
 		"  -i	--gsmtap-ip	The destination IP used for GSMTAP.\n"
 		);
 	bts_model_print_help();
@@ -145,6 +146,8 @@
 			break;
 		case 'r':
 			rt_prio = atoi(optarg);
+			fprintf(stderr, "Parameter -r is deprecated, use VTY cpu-sched "
+				"node setting 'policy rr %d' instead\n", rt_prio);
 			break;
 		case 'i':
 			gsmtap_ip = optarg;
@@ -238,6 +241,7 @@
 	osmo_stats_init(tall_bts_ctx);
 	vty_init(&bts_vty_info);
 	ctrl_vty_init(tall_bts_ctx);
+	osmo_cpu_sched_vty_init(tall_bts_ctx);
 	rate_ctr_init(tall_bts_ctx);
 
 	handle_options(argc, argv);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19444
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ice46e406b84fa11afcc7ba31e521e7677df73cf3
Gerrit-Change-Number: 19444
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200810/04d3e685/attachment.htm>


More information about the gerrit-log mailing list