Change in osmo-mgw[master]: mgcp_protocol: remove unused variable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Aug 4 17:08:12 UTC 2020


Hello laforge,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/osmo-mgw/+/19523

to review the following change.


Change subject: mgcp_protocol: remove unused variable
......................................................................

mgcp_protocol: remove unused variable

The function allocate_port() has pointer a variable end, it even does an
OSMO_ASSERT on it, but it never uses it. Lets remove it.

Change-Id: I369361389c6276e5511c683ebd630093713bdd37
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 0 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/23/19523/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index f2fc20c..bc96462 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -370,13 +370,10 @@
 static int allocate_port(struct mgcp_endpoint *endp, struct mgcp_conn_rtp *conn)
 {
 	int i;
-	struct mgcp_rtp_end *end;
 	struct mgcp_port_range *range;
 	unsigned int tries;
 
 	OSMO_ASSERT(conn);
-	end = &conn->end;
-	OSMO_ASSERT(end);
 
 	range = &endp->cfg->net_ports;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I369361389c6276e5511c683ebd630093713bdd37
Gerrit-Change-Number: 19523
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200804/12821be9/attachment.htm>


More information about the gerrit-log mailing list