Change in libosmo-abis[master]: trau_sync: prevent false positive synchronization on startup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 3 00:58:16 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19515 )


Change subject: trau_sync: prevent false positive synchronization on startup
......................................................................

trau_sync: prevent false positive synchronization on startup

The history buffer is filled with zeros on startup. Together with
incoming bits those may appear as a valid signal. (each trau frame
begins with 16 zeros). In order to prevent this lets set the history
buffer to all ones, so that it looks like the data in the history
buffer is from an unused timeslot.

Change-Id: Ie5cc7b9a1ab3d8940ef9d2147f5999e8d09ee40e
Related: OS#2547
---
M src/trau/trau_sync.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/15/19515/1

diff --git a/src/trau/trau_sync.c b/src/trau/trau_sync.c
index c4baad6..dfd7ce4 100644
--- a/src/trau/trau_sync.c
+++ b/src/trau/trau_sync.c
@@ -502,6 +502,12 @@
 	/* FIXME: this must be configurable */
 	tss->pattern = &sync_patterns[pat_id];
 
+	/* An unusued E1 timeslot normally would send an idle signal that
+	 * has all bits set to one. In order to prevent false-positive
+	 * synchronization on startup we set all history bits to 1, to make
+         * it look like a signal from an unused timeslot. */
+	memset(tss->history, 1, sizeof(tss->history));
+
 	return fi;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie5cc7b9a1ab3d8940ef9d2147f5999e8d09ee40e
Gerrit-Change-Number: 19515
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200803/0b25030a/attachment.htm>


More information about the gerrit-log mailing list