Change in osmocom-bb[master]: Wrote twl3025_power_off_now to restart the phone if the power button ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Aug 1 15:35:23 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19482 )

Change subject: Wrote twl3025_power_off_now to restart the phone if the power button is pressed.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/19482/1/src/target/firmware/abb/twl3025.c 
File src/target/firmware/abb/twl3025.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/19482/1/src/target/firmware/abb/twl3025.c@216 
PS1, Line 216: void
Let's rather add a boolean flag (e.g. 'now') here, instead of adding another (almost identical) function.


https://gerrit.osmocom.org/c/osmocom-bb/+/19482/1/src/target/firmware/abb/twl3025.c@233 
PS1, Line 233:     
inconsistent spacing



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3
Gerrit-Change-Number: 19482
Gerrit-PatchSet: 1
Gerrit-Owner: roox <mardnh at gmx.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sat, 01 Aug 2020 15:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200801/a0a838d8/attachment.htm>


More information about the gerrit-log mailing list