This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17593 ) Change subject: mobile: add audio config, with unused audio loopback setting ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg File doc/examples/mobile/multi_ms.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63 PS2, Line 63: io-target none > take a look at vadim's audio patch: that is all about redirecting audio to a file, to a local sound […] I am fine with 'route', if you guys find it less confusing. https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538 PS2, Line 1538: vty_out(vty, " no io-target%s", VTY_NEWLINE); > pespin: why there's a "no"? simply have io-target none. > neels: the most widespread vty pattern in osmocom to switch something off is Well, io-target (or io-route) is not something that we turn on and off. We always do something with received TCH frames, dropping is an action too ;) So yeah, 'io-target none' may be better. This way we could also avoid this switch and rely on audio_io_target_name(). > pespin: And if it's the default, then don't print it. > osmith: It should probably be printed if !hide_default is set, to match the code above. ACK. This is a nice feature, and we should use it. I would also like to have such an option in other osmo-* projects. > Seems that recent developments favor omitting default behavior, but that isn't always > helping the user to understand. Personally, I slightly favor printing the defaults. Agreeing with Neels here. But here, fortunately, the user can decide whether to print everything or the diff from defaults only. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a Gerrit-Change-Number: 17593 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2020 15:03:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200430/52682aff/attachment.htm>