This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )
Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data block
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10
PS1, Line 10: otherwise the generic
: UNKNOWN gsmtap message will be sent.
> See my comment to your previous change. Return code should not redefine the GSMTAP channel type.
Well a lot of stuff shouldn't be done how it is in osmo-pcu right now, but it does it this way. Complete refactoring of all code paths to change that logic is out of the scope for this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Apr 2020 11:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200430/4264efb4/attachment.htm>