Change in osmo-hlr[master]: 2/2: fixup: add osmo_gsup_peer_id with type enum and union

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Apr 29 22:22:05 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16459 )

Change subject: 2/2: fixup: add osmo_gsup_peer_id with type enum and union
......................................................................


Patch Set 9:

An opaque data structure indeed sounds like a good solution ABI wise.

A drawback is that we can't embed such an opaque struct directly in other structs: we would need dynamic allocation again, which I'd rather avoid.

I skimmed this and the previous patch for usage:
- It is used in a few structs that are talloc'd, so it would be ok to allocate as talloc child.
- Also used as local variables in a handful of locations, where it would rapidly allocate/deallocate. (Some of those could be replaced by API skipping an allocation?)

Anyway, it's a tradeoff. Maybe rather have a future proof data structure that is transparent.

My biggest problem here is the open question how that future might look. I imagine that such a future would anyway be completely separate / orthogonal to the GSUP API and that we would do plain API bloat here for no good reason.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 9
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Apr 2020 22:22:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200429/74dded61/attachment.htm>


More information about the gerrit-log mailing list