Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 29 08:39:10 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974 )


Change subject: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI
......................................................................

library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

Change [1] introduced a regression: PCU_Tests_RAW.TC_pcuif_suspend
fails since build #443. I have no idea why the BYTEORDER should be
set to 'first' (and not 'last'), but this is the only way I could
make TITAN's RAW encoder generate a valid MCC/MNC pair again.

[1] I481a40daef3eed4a3daa687ad87c4128a13181b4

Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
---
M library/GSM_RR_Types.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/17974/1

diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index d8bf595..4dc0894 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -194,7 +194,10 @@
 	type record LocationAreaIdentification {
 		BcdMccMnc	mcc_mnc,
 		uint16_t	lac
-	} with { variant "" };
+	} with {
+		/* Otherwise '262F45'H is encoded as '24F262'H */
+		variant (mcc_mnc) "BYTEORDER(first)"
+	};
 
 	/* TS 24.008 10.5.1.4 */
 	type enumerated MobileIdentityType {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
Gerrit-Change-Number: 17974
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200429/1c63f6a5/attachment.htm>


More information about the gerrit-log mailing list