Change in osmo-ttcn3-hacks[master]: library/RLCMAC: Add partial support for EGPRS data block encoding/dec...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 28 17:04:06 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965 )

Change subject: library/RLCMAC: Add partial support for EGPRS data block encoding/decoding
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965/3/library/RLCMAC_EncDec.cc 
File library/RLCMAC_EncDec.cc:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965/3/library/RLCMAC_EncDec.cc@297 
PS3, Line 297: fprintf(stderr, "RLMAC: clone: hdr_bytes=%u extra_bits=%u (length_bytes=%u)\n", hdr_bytes, extra_bits, length_bytes);
> do we really want unconditional prints to stderr in non-error paths? same applies to more messages d […]
They are not errors, as in not supported. Regarding using TTCN3 log facilitites: indeed, they should be used, but while debugging some crash I wasn't able to find the logging generated by it (maybe it doesn't print synchronously?), so I ended up using fprintf(stderr). Since god knows what will happen after hitting one of those fprintf() (as in crash), let's use fprintf(stderr) to make sure we log something before potentially crashing.

Anyway that will be stripped at some point later. For now I'd go for merging this so we have the entire placeholders working even if only it encodes Ul Headter type and decode Dl Header type3, but that's enough to get all the tests in shape for later additions.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2bc4f877a5e17c57ffa8cf05565dc8593b45aae8
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 28 Apr 2020 17:04:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200428/19a2e71f/attachment.htm>


More information about the gerrit-log mailing list