Change in osmo-ggsn[master]: Add default APN for each EUA Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Apr 27 06:04:19 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 )

Change subject: Add default APN for each EUA Type
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c@284 
PS6, Line 284: 		argv[1] = argv[0];
> Is this legal?
It took me some time to realize that it's for backwards compatibility with 'default-apn NAME'. Please add a comment.

Also, I would rather avoid changing argv. Just add two pointers and set them depending on argc, for example:

  const char *apn_name = (argc > 1) ? argv[1] : argv[0];
  const char *apn_type = (argc > 1) ? argv[0] : "v4";



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 27 Apr 2020 06:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200427/9b6741a7/attachment.htm>


More information about the gerrit-log mailing list