This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 )
Change subject: measurement: expect at least 1 SUB frame for AMR
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@665
PS1, Line 665: if (lchan->tch_mode != GSM48_CMODE_SPEECH_AMR) {
> Can we move all these checks together with the ones above in line 643 please?
This comment has not yet been addressesd
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fd91b576ff7274caa6d4356bcd7a4fa4311219d
Gerrit-Change-Number: 17929
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 26 Apr 2020 15:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/a3848b9b/attachment.htm>