Change in osmo-ggsn[master]: Add default APN for each EUA Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun Apr 26 15:39:28 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 )

Change subject: Add default APN for each EUA Type
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

regarding usefulness of this patch: I thought you really had a specific scenario in mind. Otherwise, if you want to uspport both v4 and v6 addresses for default APN, simply set default-apn to an APN supporting both v4 and v6...

I agree with you the only real use for the feature you are adding is in the event you really want to have default working configurations for PDP contexts requesting v4, v6 or v4v6. If you think that's useful we can merge it, otherwise I see no point.

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/5/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/5/ggsn/ggsn.c@475 
PS5, Line 475: 				apn = ggsn->cfg.default_apn;
Can we have this renamed to default_apn_v4?


https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/5/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/5/ggsn/ggsn_vty.c@274 
PS5, Line 274: 	"Set a default-APN to be used if no other APN v4 matches\n"
You are missing a line here I think (for v4 word).

Btw, better use "default-apn (v4|v6|v4v6) NAME" and implement the 3 of them in one command. Same for the "no" commands.


https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/5/ggsn/ggsn_vty.c@306 
PS5, Line 306: 	"Set a default-APN to be used if no other APN v6 matches\n"
same, missing line (on all of them)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 26 Apr 2020 15:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/51c8123c/attachment.htm>


More information about the gerrit-log mailing list