Change in pysim[master]: utils.py: Add helper method to parse ePDG Identifier from hex string

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Sun Apr 26 04:43:01 UTC 2020


herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17883 )

Change subject: utils.py: Add helper method to parse ePDG Identifier from hex string
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365 
PS1, Line 365: 		if o
> shouldn't we use some generic TLV parser utility code rather than hand-coding this here?
this is addressed in future commits which I will be submitting - https://github.com/herlesupreeth/pysim/commit/62e9f32474c6ee5b72d39edc30a476932f42d4a6


https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@375 
PS1, Line 375: 		#
> maybe implent that TODO first?
I have addressed in future commits the IPv4 part. Regarding the IPv6, I still searching for a proper validation of IPv6 provided by the user. 

https://github.com/herlesupreeth/pysim/commit/611e4d03d751ee79f24eefa267db731152c1c09b



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17883
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344
Gerrit-Change-Number: 17883
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 26 Apr 2020 04:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/dcf4c148/attachment.htm>


More information about the gerrit-log mailing list