This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn.c@473 PS4, Line 473: default_apn_done: > as you can see I tried a few options here. […] why not simply create a function "select_default_apn()" which returns the 'apn' pointer and hides all the selection logic? I guess you could also live without goto then as you can simply return early. https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn_vty.c@300 PS4, Line 300: "default-apnv6 NAME", > come to think of it now, […] I agree the name is a bit odd, the dash would improve things. Ideally one would have "default-apn (v4|v6|v4v6) NAME" but of course that is not an option as it breaks compatibility with old configs that just state "default-apn" Maybe "default-apn NAME [(v4|v6|v4v6)]" would work. If the final argument is not specified, v4 is assumed as a default. This way it's backwards compatible. Same applies for "no default-apn [(v4|v6|v4v6)]". -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 25 Apr 2020 13:56:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200425/dcef97f3/attachment.htm>