This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
rafael2k gerrit-no-reply at lists.osmocom.orgrafael2k has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1608 PS4, Line 1608: static void dsp_alive_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp, void *data) > The one that doesn't introduce a compiler warning. […] As you can see from the comment in https://gerrit.osmocom.org/c/osmo-bts/+/11447/ , the decision at that time was: "merge this now as-is and then unify with lc15 after merge". I prefer to stick with this position. We are now bringing oc2g and lc15 codebase to a more shared codebase, making the work of unifying them an easier task later. https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1722 PS4, Line 1722: fl1h->hw_alive.dsp_alive_timer.cb = dsp_alive_timer_cb; > I read it wrong; that -EIO won't happen due to the L1 not responding. […] I'm just sending the lc15 support as done by Nutaq, with minor modifications. With the lc15/oc2g unification, we can make this code better. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib16e7d423fc7030573acd86fbd356ae96697ed5d Gerrit-Change-Number: 17855 Gerrit-PatchSet: 6 Gerrit-Owner: rafael2k <rafael at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: rafael2k <rafael at rhizomatica.org> Gerrit-CC: keith <keith at rhizomatica.org> Gerrit-Comment-Date: Tue, 21 Apr 2020 12:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith at rhizomatica.org> Comment-In-Reply-To: rafael2k <rafael at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200421/20f68421/attachment.htm>