This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
guilly@gmail.com gerrit-no-reply at lists.osmocom.orgguilly at gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 ...................................................................... Patch Set 7: (3 comments) > Patch Set 6: Code-Review+2 looks like there was a merge conflict, where can I see the problem with it? I rebased to the latest master, and still can apply the commit is it a coding standard or another check I am missing? https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@124 PS1, Line 124: data_chunk > Let's rather call it 'chunk_len', the current name is confusing. Ack https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@124 PS1, Line 124: 0xff > Do we really need to do (X & 0xff) where X is always <= 0xff? Ack https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@126 PS1, Line 126: sw > We may probably want to check sw here. Ack -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a Gerrit-Change-Number: 17848 Gerrit-PatchSet: 7 Gerrit-Owner: guilly at gmail.com <guilly at gmail.com> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: guilly at gmail.com <guilly at gmail.com> Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 21 Apr 2020 09:12:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200421/69261771/attachment.htm>