Change in osmo-gsm-tester[master]: suites/4g: Introduce sample handover test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 21 07:45:17 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901 )

Change subject: suites/4g: Introduce sample handover test
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py 
File sysmocom/suites/4g/handover.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py@47 
PS6, Line 47:     if num_handovers != 2:
> and check here for exactly 2 HO. […]
The usual way is having the code in a function under 4g/lib/testlib.py and then having several python files (tests) calling that function (see gprs/ suite for instance). If you really want to make some values modifiable every run (is it really needed on the usual workflow?) then I'd go for use of ENV VARS in the test itself.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0dff4af7e3a89804a03842ad4a4d697bca3a9773
Gerrit-Change-Number: 17901
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 07:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200421/c70109a1/attachment.htm>


More information about the gerrit-log mailing list