This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
srs_andre gerrit-no-reply at lists.osmocom.orgsrs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901 ) Change subject: suites/4g: Introduce sample handover test ...................................................................... Patch Set 6: Code-Review-1 (5 comments) Looks good. Only a few comments on the reusability of the HO test mainly https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/src/osmo_gsm_tester/obj/ms_srs.py File src/osmo_gsm_tester/obj/ms_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/src/osmo_gsm_tester/obj/ms_srs.py@284 PS6, Line 284: def _get_counter_handover_success(self): very clever, I like this idea and already have a few more counters ;-) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl File src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl@75 PS6, Line 75: ho_active = true; can be left to false until we finish HO in the eNB https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py File sysmocom/suites/4g/handover.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py@24 PS6, Line 24: proc = iperf3cli.prepare_test_proc(False, ue.netns(), 30) can you think of a way to somehow parameterize that test? we already have the iperf time, that's one thing, but more comes below .. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py@41 PS6, Line 41: while step < len(cell1_att_li): we iterate once through the list .. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901/6/sysmocom/suites/4g/handover.py@47 PS6, Line 47: if num_handovers != 2: and check here for exactly 2 HO. The reason I am asking is because we sometime want to run a HO test for 10 minutes and sometimes for 24h. For 24h we would expect >4000 HO perhaps. But the test is essentially the same so it would make sense to parameterize the runtime and pass/fail check. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0dff4af7e3a89804a03842ad4a4d697bca3a9773 Gerrit-Change-Number: 17901 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Mon, 20 Apr 2020 18:55:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/564843b4/attachment.htm>