This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
rafael2k gerrit-no-reply at lists.osmocom.orgrafael2k has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1608 PS4, Line 1608: static void dsp_alive_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp, void *data) > I'm not sure how much it really matters, but should we not avoid introduction of yet more compiler w […] There are not really 2 or more different code paths here. Nothing to return... void makes sense. https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1722 PS4, Line 1722: fl1h->hw_alive.dsp_alive_timer.cb = dsp_alive_timer_cb; > an osmo_timer_list cb expects void, but […] As a callback which the return value nobody takes cares, fixing this has no semantic effect. The same warnings are in oc2g code. I would prefer to spend time unifying oc2g and litecell 1.5 code paths instead of fixing individual warnings here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib16e7d423fc7030573acd86fbd356ae96697ed5d Gerrit-Change-Number: 17855 Gerrit-PatchSet: 4 Gerrit-Owner: rafael2k <rafael at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: rafael2k <rafael at rhizomatica.org> Gerrit-CC: keith <keith at rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Apr 2020 15:53:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/366e4219/attachment.htm>