This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/17874 ) Change subject: SMS-over-GSUP: notify sender about malformed GSUP messages ...................................................................... SMS-over-GSUP: notify sender about malformed GSUP messages Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889 --- M src/libmsc/gsm_04_11_gsup.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/17874/1 diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index cf9d11d..7c9b6fb 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -178,9 +178,8 @@ return 0; msg_error: - /* TODO: notify sender about that? */ - LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", - msg_name, msg_is_err ? "Err" : "Res"); + LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", msg_name, msg_is_err ? "Err" : "Res"); + gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO); return -EINVAL; } @@ -269,8 +268,8 @@ return 0; msg_error: - /* TODO: notify sender about that? */ LOGP(DLSMS, LOGL_NOTICE, "RX malformed MT-forwardSM-Req\n"); + gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889 Gerrit-Change-Number: 17874 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/15b4bcb8/attachment.htm>