Change in osmo-msc[master]: SMS-over-GSUP: respond with error if net->sms_over_gsup is false

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Apr 20 03:52:24 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/17872 )


Change subject: SMS-over-GSUP: respond with error if net->sms_over_gsup is false
......................................................................

SMS-over-GSUP: respond with error if net->sms_over_gsup is false

Change-Id: If14f8a394e691f86e0acbffb283c3862fe62ffd2
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/17872/1

diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1751655..a24c617 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -282,9 +282,9 @@
 
 	/* Make sure that 'SMS over GSUP' is expected */
 	if (!net->sms_over_gsup) {
-		/* TODO: notify sender about that? */
 		LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO/MT SMS over GSUP "
 			"(sms-over-gsup is not enabled), ignoring message...\n");
+		gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_GPRS_NOTALLOWED);
 		return -EIO;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If14f8a394e691f86e0acbffb283c3862fe62ffd2
Gerrit-Change-Number: 17872
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/93bd4897/attachment.htm>


More information about the gerrit-log mailing list