Change in libosmocore[master]: timerfd: call osmo_fd_unregister() when closing on read error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 19 08:27:28 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17858 )

Change subject: timerfd: call osmo_fd_unregister() when closing on read error
......................................................................

timerfd: call osmo_fd_unregister() when closing on read error

Change-Id: I8513126286083ebf02d14043cf072c8297878dd7
---
M src/select.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/select.c b/src/select.c
index f0c814b..8e31205 100644
--- a/src/select.c
+++ b/src/select.c
@@ -382,6 +382,7 @@
 
 		rc = osmo_fd_register(ofd);
 		if (rc < 0) {
+			osmo_fd_unregister(ofd);
 			close(ofd->fd);
 			ofd->fd = -1;
 			return rc;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17858
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8513126286083ebf02d14043cf072c8297878dd7
Gerrit-Change-Number: 17858
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200419/e7332369/attachment.htm>


More information about the gerrit-log mailing list