Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

rafael2k gerrit-no-reply at lists.osmocom.org
Sat Apr 18 13:20:16 UTC 2020


rafael2k has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17808 )

Change subject: osmo-bts-litecell15: Implement missing features.
......................................................................


Patch Set 2:

(2 comments)

> Patch Set 2:
> 
> > Description set to "I'm not sure why there is a case with failing
>  > build, as the software build and runs fine in the LC 1.5."
> 
> Hi Juba, If you follow the jenkins link to the build, you can see which build failed, there you can access the entire log for the build. 
> 
> There, at least, we can see:
>  
> lc15bts.c:126:7: error: ‘Litecell15_PrimId_SetMaxCellSizeReq’ undeclared (first use in this function)
> 
> That certainly looks wrong. As I already flagged this might come up, I'd verify the LC15 headers being used for the build on jenkins.
> 
> There's also a whole bunch of other warnings there that should probably be cleaned up?

I'm fixing the problems in the rafael2k/litecell15_missing_features. Soon I'll send another patch.

https://gerrit.osmocom.org/c/osmo-bts/+/17808/2/src/osmo-bts-litecell15/l1_if.c 
File src/osmo-bts-litecell15/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17808/2/src/osmo-bts-litecell15/l1_if.c@1268 
PS2, Line 1268: if(
> coding style: missing space
Done


https://gerrit.osmocom.org/c/osmo-bts/+/17808/2/src/osmo-bts-litecell15/l1_if.c@1281 
PS2, Line 1281: if(
> coding style: missing space
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id41bba798440b00a3b11441b64b2e8094a946bf2
Gerrit-Change-Number: 17808
Gerrit-PatchSet: 2
Gerrit-Owner: rafael2k <rafael at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: rafael2k <rafael at rhizomatica.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Sat, 18 Apr 2020 13:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200418/8060948a/attachment.htm>


More information about the gerrit-log mailing list