Change in pysim[master]: cards.py: added read_sst_raw and read_sst methods

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

guilly@gmail.com gerrit-no-reply at lists.osmocom.org
Sat Apr 18 09:27:09 UTC 2020


guilly at gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17827 )

Change subject: cards.py: added read_sst_raw and read_sst methods
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > (1 comment)
> > 
> > yes, I missed the implementation in utils.py, found it later. I also agree that would be nice a more generic approach to avoid code duplication (that's one of the reasons for splitting into a _raw function). But I saw the same approach for the PLMN tables, so thought it would be ok
> > Probably this will need to be refactored to support the 31101 standard anyway, which uses a different table. Still thinking about how to do it, this was just a "generic" submission, feel free to reject it
> 
> Btw, I have a generic implementation in my forked repo (https://github.com/herlesupreeth/pysim). I am just waiting for gerrit reviews (17833 and 17834) to go through master as they are bit crucial for the further commits.

ah, nice you already have the 31101 table there, I also had that in the pipeline. I also started at github, but will try to stick to gerrit, to avoid divergences. All I need is helper functions to read the SIM after all, would be nice if you can have that merged soon :-)


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4e85b3e6c25ede4ad4c3c46db83f8314864a036f
Gerrit-Change-Number: 17827
Gerrit-PatchSet: 1
Gerrit-Owner: guilly at gmail.com <guilly at gmail.com>
Gerrit-Assignee: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: guilly at gmail.com <guilly at gmail.com>
Gerrit-CC: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 09:27:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200418/d1eb3de5/attachment.htm>


More information about the gerrit-log mailing list