This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
herlesupreeth gerrit-no-reply at lists.osmocom.orgherlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17827 ) Change subject: cards.py: added read_sst_raw and read_sst methods ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/17827/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/17827/1/pySim/cards.py@239 PS1, Line 239: def read_sst(self): First of all, pretty function you wrote here, great job. However I would like to point out that there is already such a function called parse_st in utils.py which takes the raw S/U/I Service Table hex string and returns an array of available/activated services. Also, this function is applicable to just SST and since there is also UST and IST tables a more generic solution would be good just to avoid code duplication. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e85b3e6c25ede4ad4c3c46db83f8314864a036f Gerrit-Change-Number: 17827 Gerrit-PatchSet: 1 Gerrit-Owner: guilly at gmail.com <guilly at gmail.com> Gerrit-Assignee: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Comment-Date: Sat, 18 Apr 2020 05:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200418/aeb6c656/attachment.htm>