This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@124 PS1, Line 124: data_chunk Let's rather call it 'chunk_len', the current name is confusing. https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@124 PS1, Line 124: 0xff Do we really need to do (X & 0xff) where X is always <= 0xff? https://gerrit.osmocom.org/c/pysim/+/17848/1/pySim/commands.py@126 PS1, Line 126: sw We may probably want to check sw here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a Gerrit-Change-Number: 17848 Gerrit-PatchSet: 1 Gerrit-Owner: guilly at gmail.com <guilly at gmail.com> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 17 Apr 2020 17:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200417/cd749895/attachment.htm>