Change in osmo-hlr[master]: Cosmetic: mention OS#4491 in location cancel code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 17 10:14:25 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/17815 )

Change subject: Cosmetic: mention OS#4491 in location cancel code
......................................................................

Cosmetic: mention OS#4491 in location cancel code

Change-Id: Idce0816172b92699d86ba3574a4fded0b73333cf
---
M src/hlr.c
M src/luop.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/hlr.c b/src/hlr.c
index e66444d..ac6afc3 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -401,7 +401,7 @@
 	/* TODO: Set subscriber tracing = deactive in VLR/SGSN */
 
 #if 0
-	/* Cancel in old VLR/SGSN, if new VLR/SGSN differs from old */
+	/* Cancel in old VLR/SGSN, if new VLR/SGSN differs from old (FIXME: OS#4491) */
 	if (luop->is_ps == false &&
 	    strcmp(subscr->vlr_number, vlr_number)) {
 		lu_op_tx_cancel_old(luop);
diff --git a/src/luop.c b/src/luop.c
index 1a2f854..e63ba91 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -194,7 +194,7 @@
 	lu_op_free(luop);
 }
 
-/*! Send Cancel Location to old VLR/SGSN */
+/*! Send Cancel Location to old VLR/SGSN (FIXME: OS#4491) */
 void lu_op_tx_cancel_old(struct lu_operation *luop)
 {
 	struct osmo_gsup_message gsup;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/17815
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Idce0816172b92699d86ba3574a4fded0b73333cf
Gerrit-Change-Number: 17815
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200417/c089a589/attachment.htm>


More information about the gerrit-log mailing list