This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17805 ) Change subject: transceiver: get rid of the ctrl threads ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/17805/5/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17805/5/Transceiver52M/Transceiver.cpp@762 PS5, Line 762: s.txmsgqueue.push_back(m); > @Hoernchen can you confirm this is copied? yes, the default compiler generated copy constructor for objects in c++ creates shallow (= bit exact) copies of objects, so the actual object is owned by the queue, and can therefore be automatically destructed upon destruction of the queue, too. it's just like assigning a struct that contains a char array (not a pointer, the array itself!) to another struct with = in C, you get a 1:1 copy of the whole struct, including the array. the fact that the original (temporary) object that gets copied resides on the stack of the caller is therefore not important. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642a34451e1825eafecf71a902df916ccee7944c Gerrit-Change-Number: 17805 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 13 Apr 2020 21:15:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200413/d71b643a/attachment.htm>