Change in osmo-bts[master]: osmo-bts-litecell15: Increase max_cell_size.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Mon Apr 13 21:13:48 UTC 2020


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17807 )

Change subject: osmo-bts-litecell15: Increase max_cell_size.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/17807/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/17807/3//COMMIT_MSG@9 
PS3, Line 9: Nuran's osmo-bts branch - https://gitlab.com/nrw_noa/osmo-bts use 166 as default. Previous hardcoded u8MaxCellSize was 90, which provided a ~12km maximum cell size, which is clearly not the max cell size of a real Litecell 1.5.
I don't usually see long lines like this in commit messages.
Can you configure your editor to line break?


https://gerrit.osmocom.org/c/osmo-bts/+/17807/2/src/osmo-bts-litecell15/l1_if.c 
File src/osmo-bts-litecell15/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17807/2/src/osmo-bts-litecell15/l1_if.c@1303 
PS2, Line 1303: 		/* This is the default value in osmo-bts's manufacturer branch */
Isn't osmo-bts's manufacturer confusing? Let's be more specific.


https://gerrit.osmocom.org/c/osmo-bts/+/17807/2/src/osmo-bts-litecell15/l1_if.c@1304 
PS2, Line 1304: 		sysp->u.activateRfReq.u8MaxCellSize = 166;
This is fine, but why not actually implement the vty command as in the Nuran branch once and for all?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17807
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I05b9021580f619dfddb9418f6f78164e99e5f6af
Gerrit-Change-Number: 17807
Gerrit-PatchSet: 2
Gerrit-Owner: rafael2k <rafael at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: rafael2k <rafael at rhizomatica.org>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Mon, 13 Apr 2020 21:13:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200413/19ebdb5d/attachment.htm>


More information about the gerrit-log mailing list