Change in libosmocore[master]: fix libtool issue with clang and sanitizer

[Hoernchen]

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17784 )


Change subject: fix libtool issue  with clang and sanitizer
......................................................................

fix libtool issue  with clang and sanitizer

As pointed out at https://github.com/libexpat/libexpat/issues/312
libtool does not play nice with clang sanitizer builds at all.
For those builds LD shoud be set to clang too (and LDFLAGS needs the
sanitizer flags as well), because the clang compiler driver knows how
linking to the sanitizer libs works, but then at a later stage libtool
fails to actually produce the shared libraries and the build fails. This
is fixed by this patch.

Addtionally LD_LIBRARY_PATH has no effect on conftest runs during
configure time, so the rpath needs to be set to the asan library path to
ensure the configure run does not fail due to a missing asan library,
i.e.:

SANS='-fsanitize=memory -fsanitize-recover=all -shared-libsan'
export CC=clang-10
ASANPATH=$(dirname `$CC -print-file-name=libclang_rt.asan-x86_64.so`)
export LDFLAGS="-Wl,-rpath,$ASANPATH $SANS $LDFLAGS"

Change-Id: I8ebd9c6d4efda41c7c8196f963d1f04d65160754
---
M configure.ac
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/17784/1

diff --git a/configure.ac b/configure.ac
index 3b4ad40..a4d48db 100644
--- a/configure.ac
+++ b/configure.ac
@@ -24,6 +24,11 @@
 
 AC_CONFIG_MACRO_DIR([m4])
 
+dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang (issue #312)
+AS_CASE(["$LD"],[*clang*],
+  [AS_CASE(["${host_os}"],
+     [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])])
+
 dnl check for pkg-config
 dnl * If pkg-config is missing, we get a "syntax error" for PKG_CHECK_MODULES.
 dnl   Instead, we want to say that pkg-config and pkg.m4 are missing.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8ebd9c6d4efda41c7c8196f963d1f04d65160754
Gerrit-Change-Number: 17784
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200410/59acff42/attachment.htm>