This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when not loglevel is set ...................................................................... Patch Set 3: (1 comment) There are some things that I do not understand, see comment in src/logging.c, PS2, line 1064 https://gerrit.osmocom.org/c/libosmocore/+/17604/2/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/17604/2/src/logging.c@1064 PS2, Line 1064: *(uint8_t*) (& > oh, this is actually a problem. I think many of our programs allocate the arrays as 'const', i.e. […] I have difficulties to understand this. To my understanding we should dynamically allocate memory for 'cat' here in this function, then copy over the contents of 'cat' from osmo_log_info and make the changes there. When done we assign osmo_log_info->cat with the location of the copy we just created. Is this correct? The function gets a const struct log_info *inf, in logging.h I find const struct log_info_cat *cat in struct log_info. Is it even possible to replace osmo_log_info->cat with a now memory location then? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e180261505062505fc4605a98023910f76cde6 Gerrit-Change-Number: 17604 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 09:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200409/91fafe40/attachment.htm>