Change in libosmocore[master]: gsm0503_coding: Fix USF encoding in MCS1-4

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 8 11:01:58 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17741 )

Change subject: gsm0503_coding: Fix USF encoding in MCS1-4
......................................................................

gsm0503_coding: Fix USF encoding in MCS1-4

osmo-gsm-tester raised an ASan warning in osmo-bts-trx  during execution
of a test with EGPRS enabled and a modem connecting to it (see OS#4483
for full trace):
==12388==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7fa20b9ab8d0 at pc 0x7fa20b982894 bp 0x7ffdfea8b9c0 sp 0x7ffdfea8b9b8
READ of size 1 at 0x7fa20b9ab8d0 thread T0
 #0 0x7fa20b982893 in gsm0503_mcs1_dl_interleave /home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bts/libosmocore/src/coding/gsm0503_interleaving.c:165

Function gsm0503_mcs1_dl_interleave() was being passed the 6-bit USF
encoding while clrearly expecting a 12 element array. TS 05.03 5.1.5.1.2
"USF precoding" also clearly states that 12bit encoding is to be used
for MCS1-4.

Fixes: OS#4483
Change-Id: I94db14de770070b17894a9071aa14391d26e776c
---
M src/coding/gsm0503_coding.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c
index 9449f4b..5592433 100644
--- a/src/coding/gsm0503_coding.c
+++ b/src/coding/gsm0503_coding.c
@@ -1176,7 +1176,7 @@
 	ubit_t iB[456];
 	const ubit_t *hl_hn = gsm0503_pdtch_hl_hn_ubit[3];
 
-	gsm0503_mcs1_dl_interleave(gsm0503_usf2six[usf], hc, dc, iB);
+	gsm0503_mcs1_dl_interleave(gsm0503_usf2twelve_ubit[usf], hc, dc, iB);
 
 	for (i = 0; i < 4; i++) {
 		gsm0503_xcch_burst_map(&iB[i * 114], &bursts[i * 116],

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17741
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I94db14de770070b17894a9071aa14391d26e776c
Gerrit-Change-Number: 17741
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200408/12ce4eda/attachment.htm>


More information about the gerrit-log mailing list