Change in osmo-bsc[master]: remove 'NAT' log category

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 3 19:33:37 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17698 )

Change subject: remove 'NAT' log category
......................................................................

remove 'NAT' log category

This dates back to a time where osmo-bsc_nat was in the same repository,
which is a long time ago.

Change-Id: Id965295dfe04f8bd5ce831db70c86f67b8dc290b
---
M include/osmocom/bsc/debug.h
M src/libfilter/bsc_msg_acc.c
M src/osmo-bsc/osmo_bsc_main.c
M tests/bsc/bsc_test.c
4 files changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/include/osmocom/bsc/debug.h b/include/osmocom/bsc/debug.h
index adc6abb..82c0703 100644
--- a/include/osmocom/bsc/debug.h
+++ b/include/osmocom/bsc/debug.h
@@ -19,7 +19,6 @@
 	DHO,
 	DHODEC,
 	DREF,
-	DNAT,
 	DCTRL,
 	DFILTER,
 	DPCU,
diff --git a/src/libfilter/bsc_msg_acc.c b/src/libfilter/bsc_msg_acc.c
index de6c4d9..8853dbb 100644
--- a/src/libfilter/bsc_msg_acc.c
+++ b/src/libfilter/bsc_msg_acc.c
@@ -96,7 +96,7 @@
 
 	lst = talloc_zero(ctx, struct bsc_msg_acc_lst);
 	if (!lst) {
-		LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list\n");
+		LOGP(DFILTER, LOGL_ERROR, "Failed to allocate access list\n");
 		return NULL;
 	}
 
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index bf68c9b..de84060 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -748,11 +748,6 @@
 		.description = "Reference Counting",
 		.enabled = 0, .loglevel = LOGL_NOTICE,
 	},
-	[DNAT] = {
-		.name = "DNAT",
-		.description = "GSM 08.08 NAT/Multiplexer",
-		.enabled = 1, .loglevel = LOGL_NOTICE,
-	},
 	[DCTRL] = {
 		.name = "DCTRL",
 		.description = "Control interface",
@@ -915,7 +910,7 @@
 
 	llist_for_each_entry(msc, &bsc_gsmnet->bsc_data->mscs, entry) {
 		if (osmo_bsc_msc_init(msc) != 0) {
-			LOGP(DNAT, LOGL_ERROR, "Failed to start up. Exiting.\n");
+			LOGP(DMSC, LOGL_ERROR, "Failed to start up. Exiting.\n");
 			exit(1);
 		}
 	}
diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c
index 86b7282..6079ec5 100644
--- a/tests/bsc/bsc_test.c
+++ b/tests/bsc/bsc_test.c
@@ -192,11 +192,6 @@
 		.color = "\033[1;36m",
 		.enabled = 1, .loglevel = LOGL_INFO,
 	},
-	[DNAT] = {
-		.name = "DNAT",
-		.description = "GSM 08.08 NAT/Multiplexer",
-		.enabled = 1, .loglevel = LOGL_NOTICE,
-	},
 	[DMSC] = {
 		.name = "DMSC",
 		.description = "Mobile Switching Center",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17698
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id965295dfe04f8bd5ce831db70c86f67b8dc290b
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200403/5fbb3927/attachment.htm>


More information about the gerrit-log mailing list