This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
miaoski gerrit-no-reply at lists.osmocom.orgmiaoski has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17694 ) Change subject: pySim-prog.py: check whether IMSI and PLMN matches ...................................................................... Patch Set 1: > Patch Set 1: > > I think this doesn't really solve the problem, sorry. > > The point is basically: --mcc and --mnc are *only* used in gen_parameters(), which is only used for ICCID and/or IMSI generation if you don't specify either of those two. Would you tell me more about it? IMHO, - mcc/mnc are extracted from IMSI for CSV mode in read_params_csv() - gen_parameters() deals with cmdline mode Therefore, we have a design choice here, either, 1. Check whether mcc/mnc mismatch with IMSI (current patch) 2. Reject -x and -y when IMSI is provided Which one do you want to choose (or maybe there is a third choice)? Thanks. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic7e98b827f32f8d59d346ceac0d2d215e0180109 Gerrit-Change-Number: 17694 Gerrit-PatchSet: 1 Gerrit-Owner: miaoski <miaoski at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: miaoski <miaoski at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 02 Apr 2020 02:32:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200402/db804ca5/attachment.htm>