Change in osmo-gsm-tester[master]: iperf3: add config to adjust the duration of the iperf run

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Wed Apr 1 09:36:26 UTC 2020


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 )

Change subject: iperf3: add config to adjust the duration of the iperf run
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py 
File src/osmo_gsm_tester/iperf3.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py@158 
PS6, Line 158:         if time_sec is not None:
> if time_sec is None:
Ack


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py@159 
PS6, Line 159:             values = dict(iperf3cli=config.get_defaults('iperf3cli'))
> You can really drop the iperf3cli dictionary here, since it's not really useful at all: […]
Ack


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/resource.py 
File src/osmo_gsm_tester/resource.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/resource.py@117 
PS2, Line 117:         'iperf3cli[].time': schema.STR,
> schema.TIME_DURATION, […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 6
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 09:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/4e8a5fe5/attachment.htm>


More information about the gerrit-log mailing list